On 29.03.2023 02:27, Konrad Dybcio wrote:
>
>
> On 29.03.2023 02:08, Dmitry Baryshkov wrote:
>> Employ existing PMK8350_SID and switch sc8280xp-pmics to use
>> pmk8350.dtsi to reduce duplication and possible discrepancies.
>>
>> For example, this changes sc8280xp platforms to use qcom,pmk8350-pon
>> for the pon device compatibility rather than the incorrect
>> qcom,pm8998-pon.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
>> ---
> Bit of a loaded patch..
>
> This could probably go like:
>
> 1. outer join 8280 on pmk8350 (for feature parity)
> 2. rename all labels in 8280 to 8350 (for 3.)
> 3. switch over to the actual 8350 file, remove 8280 (with Fixes:)
>
> [...]
>
>> +#define PMK8350_SID 0
>> +#include "pmk8350.dtsi"
>> +#undef PMK8350_SID
> Not sure if this undef is necessary
It looks like it would be for multiple instances though
Konrad
>
> With or without all that though, the goal lgtm..
>
> Konrad
>
>>
>> +&spmi_bus {
>> pmc8280_1: pmic@1 {
>> compatible = "qcom,pm8350", "qcom,spmi-pmic";
>> reg = <0x1 SPMI_USID>;
