On Thu, 20 Nov 2014, Sascha Hauer wrote: > On Wed, Nov 19, 2014 at 05:04:54PM +0000, Lee Jones wrote: > > On Tue, 18 Nov 2014, Sascha Hauer wrote: > > > > > On Tue, Nov 18, 2014 at 11:46:45AM +0000, Lee Jones wrote: > > > > On Mon, 17 Nov 2014, Flora Fu wrote: > > > > > > > > > Add PMIC wrapper of MT8135 to access MFD MT6397. > > > > > This is regmap of MT6397 MFD. > > > > > > > > > > Signed-off-by: Flora Fu <flora.fu@xxxxxxxxxxxx> > > > > > --- > > > > > drivers/mfd/Kconfig | 8 + > > > > > drivers/mfd/Makefile | 1 + > > > > > drivers/mfd/mt8135-pmic-wrap.c | 847 +++++++++++++++++++++++++++++++++++++++++ > > > > > > > > All of the PMIC functionality needs removing from MFD and placed > > > > somewhere else. I suggest either drivers/power or drivers/regulator. > > > > > > This is no PMIC functionality. The MT8135 has a unit which is is used to > > > access the PMIC (which is not only a PMIC, but also Touchscreen > > > interface and other stuff). This unit is called pmic-wrapper in the > > > docs. See the introductory mail for a nice picture. > > > > I saw the picture, it's very nice. Whatever this is, it's not an > > MFD. It's a device which is located on an MFD. There is far too much > > functional (the operative word here) code contained in this patch. > > The MT6397 is a classical MFD device. It has a PMIC, an audio amp and a > RTC. It is very tightly coupled to the SoC via SPI, but the SPI itself > is not directly visible on the SoC. It's accessible indirectly via the > PMIC-wrapper. Indeed the PMIC-wrapper is not MFD. Another dumping ground > that comes to my mind is drivers/soc/. We could move over there. Thanks for understanding my point-of-view. Hopefully there is a suitable "dumping ground", or even better a proper place to move the PMIC-wrapper to. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
