Re: [PATCH 0/9] ASoC: QCOM: Add support for ipq806x SOC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Wed, Nov 19, 2014 at 02:16:10PM -0600, Kumar Gala wrote:

Kumar, as I keep saying please fix your mailer to word wrap within
paragraphs.

> Some general comments, you shouldn’t have gerrit Change-Id’s in commit

Indeed.

> messages, the Kconfig/Makefile changes should be part of the patch
> that adds the code associated with them.

No, it's totally fine for a large new driver like this that's split over
many commits to add the Kconfig and Makefile at the end - there is no
value in trying to split them up.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux