On 24/03/2023 03:28, Samin Guo wrote: > From: Yanhong Wang <yanhong.wang@xxxxxxxxxxxxxxxx> > > Add documentation to describe StarFive dwmac driver(GMAC). > > Signed-off-by: Yanhong Wang <yanhong.wang@xxxxxxxxxxxxxxxx> > Signed-off-by: Samin Guo <samin.guo@xxxxxxxxxxxxxxxx> > + starfive,syscon: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + items: > + - items: > + - description: phandle to syscon that configures phy mode > + - description: Offset of phy mode selection > + - description: Shift of phy mode selection > + description: > + A phandle to syscon with two arguments that configure phy mode. > + The argument one is the offset of phy mode selection, the > + argument two is the shift of phy mode selection. > + > +allOf: > + - $ref: snps,dwmac.yaml# > + > +unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - interrupts > + - interrupt-names > + - resets > + - reset-names required: goes after properties: Just like in example-schema. *With* fix above: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof