On 26/03/2023 01:57, Dmitry Baryshkov wrote: > Migrate legacy bindings (described in qcom,sc7180-qmp-usb3-dp-phy.yaml) > to qcom,sc8280xp-qmp-usb43dp-phy.yaml. This removes a need to declare > the child PHY node or split resource regions. Thank you for your patch. There is something to discuss/improve. > - resets: > - items: > - - description: reset of phy block. > - - description: phy common block reset. > - > - reset-names: > - items: > - - const: phy > - - const: common > - > - vdda-phy-supply: > - description: > - Phandle to a regulator supply to PHY core block. > - > - vdda-pll-supply: > - description: > - Phandle to 1.8V regulator supply to PHY refclk pll block. > - > - vddp-ref-clk-supply: > - description: > - Phandle to a regulator supply to any specific refclk pll block. What about this supply. It's missing in the new binding. Don't we need it? Isn't it a real supply? Best regards, Krzysztof
