Hi Krzysztof, On Sun, 2023-03-26 at 10:55 +0200, Krzysztof Kozlowski wrote: > On 25/03/2023 14:44, Dylan Van Assche wrote: > > Document the added qcom,assign-all-memory in devicetree bindings. > > > > Signed-off-by: Dylan Van Assche <me@xxxxxxxxxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 6 > > ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml > > b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml > > index 1ab9588cdd89..fa5b00534b30 100644 > > --- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml > > +++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml > > @@ -57,6 +57,12 @@ properties: > > Virtual machine IDs for remote processor. > > $ref: "/schemas/types.yaml#/definitions/uint32-array" > > > > + qcom,assign-all-mem: > > + description: > > + Assign memory to all Virtual machines defined by qcom,vmids. > > This (neither commit msg) does not explain why this is needed and > actually does not sound like hardware-related property. This is made a separate property to toggle different behavior in the driver if it is needed for some FastRPC nodes. Downstream does guard this with a property 'restrict-access' as well, see [1] for a random SDM845 downstream kernel. On SDM845, this property is not present, thus the IF block runs. On SDM670, this property is present, then the IF block is skipped. That's why I opt for this property to have this behaviour conditionally. I'm not sure how to explain it better though. Any feedback is appreciated, thanks! Kind regards, Dylan Van Assche [1] https://github.com/SHIFTPHONES/android_kernel_shift_sdm845/blob/sos-3.x/drivers/char/adsprpc.c#L4615-L4631 > > > + type: boolean > > + > > + > > Do not add double blank lines. > > > "#address-cells": > > const: 1 > > > > Best regards, > Krzysztof >
