> Missing bindings documentation.
> Please run scripts/checkpatch.pl and fix reported warnings.
Sorry I was missing the DTS bindings patch, will send that
one over this evening
On Sun, Mar 26, 2023 at 10:38 AM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 26/03/2023 01:15, Shane Francis wrote:
> > This adds basic support for the NanoPi R6S SBC
> >
> > Currently working :
> > - UART
> > - mmc storage (internal)
> > - RGMII / GMAC 1Gb ethernet
> > - SYS LED
> >
> > Signed-off-by: Shane Francis <bigbeeshane@xxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/rockchip/Makefile | 1 +
> > .../boot/dts/rockchip/rk3588s-nanopi-r6s.dts | 126 ++++++++++++++++++
> > 2 files changed, 127 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-nanopi-r6s.dts
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> > index 99a44c400d6a..39cad757d29d 100644
> > --- a/arch/arm64/boot/dts/rockchip/Makefile
> > +++ b/arch/arm64/boot/dts/rockchip/Makefile
> > @@ -91,3 +91,4 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-io.dtb
> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-evb1-v10.dtb
> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-rock-5b.dtb
> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5a.dtb
> > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-nanopi-r6s.dtb
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-nanopi-r6s.dts b/arch/arm64/boot/dts/rockchip/rk3588s-nanopi-r6s.dts
> > new file mode 100644
> > index 000000000000..21b26539a855
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/rockchip/rk3588s-nanopi-r6s.dts
> > @@ -0,0 +1,126 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +
> > +/dts-v1/;
> > +
> > +#include <dt-bindings/pinctrl/rockchip.h>
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include "rk3588s.dtsi"
> > +
> > +/ {
> > + model = "NanoPi R6S - RK3588S";
> > + compatible = "friendlyelec,nanopi6", "rockchip,rk3588";
>
> Missing bindings documentation.
>
> Please run scripts/checkpatch.pl and fix reported warnings.
>
> Best regards,
> Krzysztof
>
