On 25.03.2023 12:50, Krzysztof Kozlowski wrote: > On 25/03/2023 12:41, Heiner Kallweit wrote: >> On 25.03.2023 12:18, Krzysztof Kozlowski wrote: >>> On 24/03/2023 23:51, Heiner Kallweit wrote: >>>> Convert Amlogic Meson pin controller binding to yaml. >>>> > > >>>> +patternProperties: >>>> + "^bank@[0-9a-z]+$": >>>> + $ref: amlogic,meson-pinctrl-common.yaml#/$defs/meson-gpio >>>> + >>>> + properties: >>>> + reg: >>>> + maxItems: 4 >>>> + >>>> + reg-names: >>>> + items: >>>> + - const: mux >>>> + - const: pull >>>> + - const: pull-enable >>>> + - const: gpio >>>> + >>>> + unevaluatedProperties: false >>> >>> Wrong placement. Rob asked you to put it after $ref and the review was >>> conditional based on this. Don't add review-tag if you do not follow the >>> comment. >>> >> I wasn't aware that this makes a difference, and in e.g. samsung,pinctrl.yaml >> I found it at the end of the patternProperties block. >> Thanks for the hint, then I will correct this and resubmit. > > But Rob asks for it, so regardless whether it makes difference or not, > you ignore the comment? > I understood the comment as: It needs to be in the block, somewhere after the $ref. My bad. > Best regards, > Krzysztof > Heiner
