On 24.03.2023 21:22, Krzysztof Kozlowski wrote: > Bindings require pin configuration nodes to have the function, even if > it is GPIO: > > msm8916-thwc-ufi001c.dtb: pinctrl@1000000: sim-ctrl-default-state: 'oneOf' conditional failed, one must be fixed: > 'esim-sel-pins', 'sim-en-pins', 'sim-sel-pins' do not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> Konrad > arch/arm64/boot/dts/qcom/msm8916-thwc-ufi001c.dts | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916-thwc-ufi001c.dts b/arch/arm64/boot/dts/qcom/msm8916-thwc-ufi001c.dts > index 8433c9710b1c..978f0abcdf8f 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916-thwc-ufi001c.dts > +++ b/arch/arm64/boot/dts/qcom/msm8916-thwc-ufi001c.dts > @@ -44,18 +44,21 @@ &msmgpio { > sim_ctrl_default: sim-ctrl-default-state { > esim-sel-pins { > pins = "gpio0", "gpio3"; > + function = "gpio"; > bias-disable; > output-low; > }; > > sim-en-pins { > pins = "gpio1"; > + function = "gpio"; > bias-disable; > output-low; > }; > > sim-sel-pins { > pins = "gpio2"; > + function = "gpio"; > bias-disable; > output-high; > };