Hi Krzysztof, Thanks for the review comments. On Tue, Feb 28, 2023 at 11:53:51AM +0100, Krzysztof Kozlowski wrote: > On 27/02/2023 19:31, Piyush Malgujar wrote: > > From: Jayanthi Annadurai <jannadurai@xxxxxxxxxxx> > > > > Add support for SD6 controller support. > > > > Signed-off-by: Jayanthi Annadurai <jannadurai@xxxxxxxxxxx> > > Signed-off-by: Piyush Malgujar <pmalgujar@xxxxxxxxxxx> > > --- > > .../devicetree/bindings/mmc/cdns,sdhci.yaml | 24 +++++++++++++++++-- > > 1 file changed, 22 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > > index 8b1a0fdcb5e3e2e8b87d8d7678e37f3dad447fc1..0dba17c4f17f82c8ae68e46225ed72418e8361ff 100644 > > --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > > +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > > @@ -4,7 +4,7 @@ > > $id: http://devicetree.org/schemas/mmc/cdns,sdhci.yaml# > > $schema: http://devicetree.org/meta-schemas/core.yaml# > > > > -title: Cadence SD/SDIO/eMMC Host Controller (SD4HC) > > +title: Cadence SD/SDIO/eMMC Host Controller (SD4HC, SD6HC) > > > > maintainers: > > - Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> > > @@ -18,7 +18,9 @@ properties: > > - enum: > > - microchip,mpfs-sd4hc > > - socionext,uniphier-sd4hc > > - - const: cdns,sd4hc > > + - enum: > > + - cdns,sd4hc > > + - cdns,sd6hc > > I see here rather random set of changes in each version of this patch. > This does not really make sense. You are saying that existing (!!!) > mpfs-sd4hc is compatible with sd6hc. I think you wanted oneOf here, but > not sure. Can you explain what is your intention? Your commit msg is > just one line saying the same as subject, so not really helpful. > > > Best regards, > Krzysztof > Yes thank you, it should be oneOf as sd6hc is exclusive. I will correct it in the next version. Best Regards, Piyush
