On Thu, Mar 16, 2023 at 09:09:37AM +0100, Krzysztof Kozlowski wrote: > On 13/03/2023 23:51, Serge Semin wrote: > > Currently some of the boolean properties defined in the DT-schema are > > marked to have the basic boolean type meanwhile the rest referencing the > > /schemas/types.yaml#/definitions/flag schema. For the sake of unification > > let's convert the first group to referencing the pre-defined flag schema. > > Thus bindings will look a bit more coherent and the DT-bindings > > maintainers will have a better control over the booleans defined in the > > schema (if ever needed). > > > > Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> > > --- > > .../devicetree/bindings/net/snps,dwmac.yaml | 45 ++++++++++++------- > > 1 file changed, 30 insertions(+), 15 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > index 69be39d55403..a863b5860566 100644 > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > @@ -120,11 +120,13 @@ properties: > > maximum: 12 > > > > snps,rx-sched-sp: > > - type: boolean > > + $ref: /schemas/types.yaml#/definitions/flag > > description: Strict priority > > If ever touching this, it should be other way -> boolean. Ok. I'll drop the patch then. -Serge(y) > > Best regards, > Krzysztof >
