Hi Martin, Thank you for the patch! Yet something to improve: [auto build test ERROR on broonie-spi/for-next] [also build test ERROR on robh/for-next krzk-dt/for-next linus/master v6.3-rc3 next-20230322] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Martin-Kurbanov/dt-bindings-spi-add-binding-for-meson-spifc-a1/20230322-230744 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next patch link: https://lore.kernel.org/r/20230322150458.783901-3-mmkurbanov%40sberdevices.ru patch subject: [PATCH v1 2/2] spi: add support for Meson A1 SPI Flash Controller config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230323/202303230442.lGIrV8PZ-lkp@xxxxxxxxx/config) compiler: sparc64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/7d8d54cc0b563efb979caf17507b29c0bb3efde0 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Martin-Kurbanov/dt-bindings-spi-add-binding-for-meson-spifc-a1/20230322-230744 git checkout 7d8d54cc0b563efb979caf17507b29c0bb3efde0 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303230442.lGIrV8PZ-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/spi/spi-meson-spifc-a1.c: In function 'a1_spifc_read': >> drivers/spi/spi-meson-spifc-a1.c:204:16: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration] 204 | val |= FIELD_PREP(A1_SPIFC_USER_DIN_MODE, mode); | ^~~~~~~~~~ cc1: some warnings being treated as errors vim +/FIELD_PREP +204 drivers/spi/spi-meson-spifc-a1.c 196 197 static int a1_spifc_read(struct a1_spifc *spifc, void *buf, u32 size, u32 mode) 198 { 199 u32 val = readl(spifc->base + A1_SPIFC_USER_CTRL3_REG); 200 int ret; 201 202 val &= ~(A1_SPIFC_USER_DIN_MODE | A1_SPIFC_USER_DIN_BYTES); 203 val |= A1_SPIFC_USER_DIN_ENABLE; > 204 val |= FIELD_PREP(A1_SPIFC_USER_DIN_MODE, mode); 205 val |= FIELD_PREP(A1_SPIFC_USER_DIN_BYTES, size); 206 writel(val, spifc->base + A1_SPIFC_USER_CTRL3_REG); 207 208 ret = a1_spifc_request(spifc, true); 209 if (!ret) 210 a1_spifc_drain_buffer(spifc, buf, size); 211 212 return ret; 213 } 214 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
