On 20/03/2023 11:46, Johan Hovold wrote: > Add devicetree bindings for Qualcomm ath11k PCIe devices such as WCN6856 > for which the calibration data variant may need to be described. > > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx> > --- > .../bindings/net/wireless/pci17cb,1103.yaml | 56 +++++++++++++++++++ > 1 file changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/wireless/pci17cb,1103.yaml > > diff --git a/Documentation/devicetree/bindings/net/wireless/pci17cb,1103.yaml b/Documentation/devicetree/bindings/net/wireless/pci17cb,1103.yaml > new file mode 100644 > index 000000000000..df67013822c6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/wireless/pci17cb,1103.yaml PCI devices are kind of exception in the naming, so this should be qcom,ath11k-pci.yaml or qcom,wcn6856.yaml (or something similar) > @@ -0,0 +1,56 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2023 Linaro Limited > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/wireless/pci17cb,1103.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies ath11k wireless devices (PCIe) > + > +maintainers: > + - Kalle Valo <kvalo@xxxxxxxxxx> > + > +description: | > + Qualcomm Technologies IEEE 802.11ax PCIe devices. > + > +properties: > + compatible: > + enum: > + - pci17cb,1103 # WCN6856 > + > + reg: > + maxItems: 1 > + > + qcom,ath11k-calibration-variant: qcom,calibration-variant > + $ref: /schemas/types.yaml#/definitions/string > + description: calibration data variant Your description copies the name of property. Instead say something more... > + Best regards, Krzysztof
