On Tue, Mar 21, 2023 at 8:16 AM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 21/03/2023 08:00, Sergio Paracuellos wrote: > >>> +properties: > >>> + compatible: > >>> + items: > >>> + - enum: > >>> + - ralink,mt7620-sysc > >> > >> Since you decided to send it before we finish discussion: > >> NAK - this is already used as mediatek > > > > Sorry, there was too much stuff commented so I preferred to clean up > > all of them while maintaining the compatibles with the ralink prefix > > instead since that was where the current discussion was at that point. > > You did not even wait for me to send feedback on this, in old thread. My apologies, I thought it was better to send it at that point. Will wait for feedback from now on before sending anything. > > > > >> > >>> + - ralink,mt7620a-sysc > > > > As I have said, this one exists: > > > > arch/mips/ralink/mt7620.c: rt_sysc_membase = > > plat_of_remap_node("ralink,mt7620a-sysc"); > > And why do you ignore others which have mediatek? > > > > > > >>> + - ralink,mt7628-sysc > >> > >> Same here. > > Same problem. > > >> > >>> + - ralink,mt7688-sysc > >> > >> I expect you to check the others. > > > > I can change others to mediatek but that would be a bit weird, don't you think? > > No, I expect to have mediatek where the model is already used with > mediatek prefix. It is clear now, thanks. > > > > Best regards, > Krzysztof > Thanks Krzysztof. Best regards, Sergio Paracuellos