On 2023/3/20 23:14, Rob Herring wrote: > On Wed, Mar 15, 2023 at 03:04:19AM -0700, Changhuang Liang wrote: >> [...] >> + resets: >> + items: >> + - description: DPHY_HW reset >> + - description: DPHY_B09_ALWAYS_ON reset >> + >> + starfive,aon-syscon: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + items: >> + - items: >> + - description: phandle of AON SYSCON >> + - description: register offset >> + description: The power of dphy rx is configured by AON SYSCON >> + in this property. > > Sounds like AON SYSCON should be a power-domains provider. Custom > phandle links are for things which don't fit standard bindings. > Hi, Rob In starfive jh7110 SoC，we have achieved the power-domains provider as follow: https://patchwork.kernel.org/project/linux-pm/cover/20230119094447.21939-1-walker.chen@xxxxxxxxxxxxxxxx/ But this AON SYSCON is a miscellaneous register. It different offsets configure the different functions of the different modules. So we don't make a framework fot it. What do you think? Thanks >> + >> + "#phy-cells": >> + const: 0 >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + - clock-names >> + - resets >> + - starfive,aon-syscon >> + - "#phy-cells" >> [...] >>
