On Mon, Nov 17, 2014 at 1:32 PM, Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> wrote: > On 10/25/2014 01:40 AM, Lina Iyer wrote: > > Hi Lina, > > [ ... ] > >> +static inline void spm_register_write(struct spm_driver_data *drv, >> + enum spm_reg reg, u32 val) >> +{ >> + if (drv->reg_data->reg_offset[reg]) >> + writel_relaxed(val, drv->reg_base + >> + drv->reg_data->reg_offset[reg]); > > > Why not use writel and don't use 'wmb' below ? > Hi Daniel, writel() provides ordering before the write, not after. Please have a look at the definition. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html