On Thu, Mar 16, 2023 at 8:31 AM Devi Priya <quic_devipriy@xxxxxxxxxxx> wrote: > Add pinctrl definitions for the TLMM of IPQ9574 > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Co-developed-by: Anusha Rao <quic_anusha@xxxxxxxxxxx> > Signed-off-by: Anusha Rao <quic_anusha@xxxxxxxxxxx> > Signed-off-by: Devi Priya <quic_devipriy@xxxxxxxxxxx> > --- > Changes in V9: > - Added COMPILE_TEST for non-OF configurations in config PINCTRL_IPQ9574 > - Unwrapped the lines for PINGROUP 34 & 62 in ipq9574_groups > - Removed the comma from terminator line in ipq9574_pinctrl_of_match[] array > - Moved the MODULE_DEVICE_TABLE entry just below the array > ipq9574_pinctrl_of_match[] Looks good to me but I would like Bjorns ACK on this patch before I merge it if possible. Yours, Linus Walleij