On 17/03/2023 11:39, Jan Jasper de Kroon wrote: > > Op 16-03-2023 om 20:25 schreef Krzysztof Kozlowski: >> On 16/03/2023 16:29, Jan Jasper de Kroon wrote: >>> Add an optional 'goodix-hold-in-reset', to the Goodix touchscreen >>> device tree binding. When set to true, the touchscreen controller will >>> be held in reset mode during system suspend, reducing power consumption. >>> If not present, the property defaults to false. >>> >>> Signed-off-by: Jan Jasper de Kroon <jajadekroon@xxxxxxxxx> >> Don't attach new patchsets to some other threads. It messes with our >> tools and reading/reviewing process. > Thank you for bringing this to my attention. I apologize for any > inconvenience caused by attaching the patchset to the wrong threads. As a > new user of LKML, I'm still learning the appropriate protocol for > submitting patches. Going forward, I will ensure to attach patchsets to > the correct threads. >>> --- >>> Changes from v2 to v3: >>> - Used imperative mood instead of "This patch adds". >>> - Dropped "I am submitting this patch to..." as it is redundant. >>> - Removed the paragraph related to the related patch sent to the >>> linux-input mailing list as it is not necessary. >>> - Renamed the hold-in-reset-in-suspend function to >>> goodix-hold-in-reset to prevent potential naming conflicts with other >>> functions in the codebase. No functional changes were made. >>> >>> Changes from v1 to v2: >>> - Updated subject prefix to match subsystem. >>> - Added more detailed description of the change. >>> - Fixed formatting issues in commit message. >>> .../devicetree/bindings/input/touchscreen/goodix.yaml | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml >>> index 3d016b87c8df..197f8db9acc2 100644 >>> --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml >>> +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml >>> @@ -56,6 +56,13 @@ properties: >>> touchscreen-size-y: true >>> touchscreen-swapped-x-y: true >>> >>> + goodix-hold-in-reset: >> That's not a vendor prefix... missing coma. > Thank you for pointing out the mistake in the vendor prefix. I appreciate > your feedback and apologize for any inconvenience caused. I wasn't aware > of the correct vendor prefix style, but I've learned from developer Hans > de Goede that it should be "goodix,hold-in-reset." I will make sure to > correct this in my local branch and ensure that it is applied correctly in > the future. Thanks again for bringing this to my attention. >>> + description: | >>> + When set to true, the touchscreen controller will be held in reset mode >>> + during system suspend. This can help reduce power consumption, but may >>> + cause the touchscreen to take longer to resume when the system is woken >>> + up from suspend. >> Anyway, my concerns were not answered, so to be clear: >> >> NAK till you answer them. Do not send new versions without answering >> existing concerns and discussion. > Thank you again for reviewing my patchset and providing feedback. I > appreciate your time and effort in ensuring the quality and suitability > of the DeviceTree. > > Regarding the concerns you raised about the proposed feature, I would > like to address them directly. You mentioned that the property does not > look suitable for Devicetree because it describes system policies that are > not within the scope of Devicetree. While I understand your point, I > believe this property is appropriate for Devicetree for the following > reasons: > > - The property directly relates to the hardware configuration of the > device, specifically the touchscreen controller, and is not a software > policy. Keeping device in reset state is not hardware configuration but driver behavior. You did not Cc us on all patches for some reason, so it's difficult to judge what exactly your driver is doing. > > - The property is required for proper system operation and is not optional > in specific device use cases. To be more specific in the case of the > PinePhone Original and Pro. The original commit message of the driver > implementation in driver/input/touchscreen contained the following: > "It consumes quite a bit of power (~40mW) during system sleep, and more > when the screen is touched." > Because the phone is usually kept in your pocket, so prone to a lot of > screen touches, this is highly undesired behavior for the touchscreen in > this case. This in my opinion makes it a mandatory property in this > situation. Why then the touchscree should not be kept in reset for other devices? IOW, this should be always used. If you now say "I prefer to keep or not keep it in reset for my device" - it's a policy. > > - The property is not a user-facing configuration option and is not meant > to be changed by the end-user. Does not matter. > > - The property, although in separate device specific kernel, and still > called 'poweroff-in-suspend' is already in use on specific devices, > including the PinePhone Original and PinePhone Pro. I could not find such property in the kernel. > > However, I understand your concern that Devicetree should not be used for > policies. To address this concern, I would like to propose the following > changes to the property description: > 1. Remove the sentence about reducing power consumption, as this could be > considered a policy. > 2. Emphasize that the property is a required hardware configuration and > not an optional feature on certain devices. > 3. Recommend that any changes to the property value should only be made by > experienced system administrators and not end-users. Please answer - why this should not be enabled always. Best regards, Krzysztof
