On 18/03/2023 13:18, Bryan O'Donoghue wrote: > Adds a series of defines which are used in the DTS and type-c driver for > identifying interrupts. I see your driver uses them, but I don't understand why and what for... Why would we define them as bindings? We do not define interrupt numbers as bindings. Why the driver needs it? > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> > --- > .../dt-bindings/usb/typec/qcom,pmic-typec.h | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > create mode 100644 include/dt-bindings/usb/typec/qcom,pmic-typec.h > > diff --git a/include/dt-bindings/usb/typec/qcom,pmic-typec.h b/include/dt-bindings/usb/typec/qcom,pmic-typec.h > new file mode 100644 > index 0000000000000..733e23b6cdbc4 > --- /dev/null > +++ b/include/dt-bindings/usb/typec/qcom,pmic-typec.h > @@ -0,0 +1,18 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ If the file stays: dual license. And squash it with next patch. Binding headers are not a separate feature. It's the same as adding bindings. Best regards, Krzysztof
