On Fri, Mar 17, 2023 at 06:37:16PM +0100, Konrad Dybcio wrote: > On 17.03.2023 16:07, Stephan Gerhold wrote: > > On Fri, Mar 17, 2023 at 01:39:25AM +0100, Konrad Dybcio wrote: > >> On 15.03.2023 11:39, Stephan Gerhold wrote: > >>> According to the msm-3.18 vendor kernel from Qualcomm [1], mdm9607 uses > >>> a non-standard slope value of 3000 (instead of 3200) for all sensors. > >>> Fill it properly similar to the 8939 code added recently. > >>> > >>> [1]: https://git.codelinaro.org/clo/la/kernel/msm-3.18/-/blob/LE.UM.4.3.2.r1-04200-9x07/arch/arm/boot/dts/qcom/mdm9607.dtsi#L875 > >>> > >> FWIW there's a 4.9 release for 9607 > >> > >> https://git.codelinaro.org/clo/la/kernel/msm-3.18/-/blob/LE.UM.2.3.6.c5-03900-9x07/arch/arm/boot/dts/qcom/mdm9607.dtsi > > > > You seem to have linked 3.18 too? > > > > I don't see tsens support for mdm9607 in msm-4.9, although maybe I'm > > looking at the wrong branch. :D > Yeah wrong link > > and wrong kernel, it's actually 4.14 > > https://git.codelinaro.org/clo/la/kernel/msm-4.14/-/blob/637e99f66c270385149d1f0041758c24c4f84aaf/arch/arm64/boot/dts/qcom/mdm9607.dtsi > Nice, I didn't know there is mdm9607 in msm-4.14. :) Nevertheless I think msm-3.18 is a better reference for the tsens code. In 4.9+ Qualcomm originally removed support for tsens v0.1. When porting the older targets it seems to have been hacked back in with very little thought. Note how it's called tsens 14xx there instead of v0.1, just with different register offsets. Personally I wouldn't trust what they did there, especially because most mdm9607 devices in the wild use 3.18. Thanks, Stephan
