Re: [PATCH v4 17/18] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM usb-role-switching for usb_1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 18.03.2023 13:18, Bryan O'Donoghue wrote:
> Switch on usb-role-switching for usb_1 via TCPM. We need to declare
> usb-role-switch in &usb_1 and associate with the remote-endpoint in TCPM
> which provides the necessary signal.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> index 965742a5be7ae..43d549d6672e9 100644
> --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> @@ -1273,7 +1273,13 @@ &usb_1 {
>  };
>  
>  &usb_1_dwc3 {
> -	dr_mode = "peripheral";
> +	dr_mode = "otg";
> +	usb-role-switch;
This could maybe go to the SoC DTSI.. Bjorn, Krzysztof, WDYT?

Also, please add a newline before the subnode.

> +	port {
> +		dwc3_drd_switch: endpoint {
> +			remote-endpoint = <&usb3_role>;
> +		};
> +	};
DWC3 ports (@0 for HS, @1 for SS and @2 for altmode) can definitely
go to the SoC DTSI.

>  };
>  
>  &usb_1_hsphy {
> @@ -1356,6 +1362,12 @@ &pm8150b_vbus {
>  
>  &tcpm {
>  	status = "okay";
Please add a newline before the subnode.

Konrad

> +	port {
> +		usb3_role: endpoint {
> +			remote-endpoint = <&dwc3_drd_switch>;
> +		};
> +	};
> +
>  	connector {
>  		compatible = "usb-c-connector";
>  



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux