Hi Simon, On Fri, Mar 17, 2023 at 1:42 PM Simon Horman <simon.horman@xxxxxxxxxxxx> wrote: > > On Fri, Mar 17, 2023 at 01:00:11PM -0700, Luiz Augusto von Dentz wrote: > > Hi Neeraj, > > > > On Thu, Mar 16, 2023 at 10:22 AM Neeraj Sanjay Kale > > <neeraj.sanjaykale@xxxxxxx> wrote: > > > > > > This patch adds a driver for NXP bluetooth chipsets. > > > > > > The driver is based on H4 protocol, and uses serdev APIs. It supports host > > > to chip power save feature, which is signalled by the host by asserting > > > break over UART TX lines, to put the chip into sleep state. > > > > > > To support this feature, break_ctl has also been added to serdev-tty along > > > with a new serdev API serdev_device_break_ctl(). > > > > > > This driver is capable of downloading firmware into the chip over UART. > > > > > > The document specifying device tree bindings for this driver is also > > > included in this patch series. > > > > > > Neeraj Sanjay Kale (4): > > > serdev: Replace all instances of ENOTSUPP with EOPNOTSUPP > > > serdev: Add method to assert break signal over tty UART port > > > dt-bindings: net: bluetooth: Add NXP bluetooth support > > > Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets > > > > > > .../net/bluetooth/nxp,88w8987-bt.yaml | 45 + > > > MAINTAINERS | 7 + > > > drivers/bluetooth/Kconfig | 12 + > > > drivers/bluetooth/Makefile | 1 + > > > drivers/bluetooth/btnxpuart.c | 1297 +++++++++++++++++ > > > drivers/tty/serdev/core.c | 17 +- > > > drivers/tty/serdev/serdev-ttyport.c | 16 +- > > > include/linux/serdev.h | 10 +- > > > 8 files changed, 1398 insertions(+), 7 deletions(-) > > > create mode 100644 Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > > > create mode 100644 drivers/bluetooth/btnxpuart.c > > > > > > -- > > > 2.34.1 > > > > If there are no new comments to be addressed by the end of the day I'm > > planning to merge this into bluetooth-next. > > FWIIW, as someone involved in the review of this series, I am fine with that. > Even though I have only supplied tags for some of the patches; > those for which I feel that it is appropriate. Thanks for the feedback and the review as well. -- Luiz Augusto von Dentz