On Fri, Mar 17, 2023 at 01:53:17PM -0500, Rob Herring wrote: > On Tue, Mar 14, 2023 at 02:48:25PM +0300, Dmitry Rokosov wrote: > > On Tue, Mar 14, 2023 at 12:28:40PM +0100, Krzysztof Kozlowski wrote: > > > On 13/03/2023 21:12, Dmitry Rokosov wrote: > > > > [...] > > > > > > +#define CLKID_SPIFC 84 > > > > +#define CLKID_USB_BUS 85 > > > > +#define CLKID_SD_EMMC 86 > > > > +#define CLKID_PSRAM 87 > > > > +#define CLKID_DMC 88 > > > > > > And what is here? Between 88 and 121? > > > > > > > Explained below. > > > > > > +#define CLKID_GEN_SEL 121 > > > > + > > > > +#endif /* __A1_CLKC_H */ > > > > diff --git a/include/dt-bindings/clock/amlogic,a1-pll-clkc.h b/include/dt-bindings/clock/amlogic,a1-pll-clkc.h > > > > new file mode 100644 > > > > index 000000000000..8e97d3fb9d30 > > > > --- /dev/null > > > > +++ b/include/dt-bindings/clock/amlogic,a1-pll-clkc.h > > > > @@ -0,0 +1,20 @@ > > > > +/* SPDX-License-Identifier: GPL-2.0+ */ > > > > > > I found in changelog: > > > "fix license issue, it's GPL-2.0+ only in the current version" > > > and I do not understand. > > > > > > The license is wrong, so what did you fix? > > > > > > > Sorry don't get you. Why is it wrong? > > I've changed all new source files to GPL-2.0+ except yaml, because yaml > > dt bindings schemas require the following license: > > Why 2.0+? The kernel's default license is 2.0-only. Are you (and > your lawyer) okay with GPL v4? > > But this is still part of the DT binding and has the same license > preference: > > > # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > However, the header licenses are complicated due to .dts licenses which > are all over the place. The requirement is dual licensed and matching > what includes it. Agree with you. As we discussed with Krzysztof, checkpatch must verify such wrong license tags. I've introduced the patchset for that, please take a look: https://lore.kernel.org/all/20230317201621.15518-1-ddrokosov@xxxxxxxxxxxxxx/ -- Thank you, Dmitry
