Re: [PATCH v4 5/5] arm64: dts: qcom: sm8450: add dp controller

[Neil Armstrong <neil.armstrong@xxxxxxxxxx>]

On 14/03/2023 23:12, Konrad Dybcio wrote:
> On 9.03.2023 10:19, Neil Armstrong wrote:
> > Add the Display Port controller subnode to the MDSS node.
> >
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > ---
> [...]
> > +
> > +				dp_opp_table: opp-table {
> > +					compatible = "operating-points-v2";
> > +
> > +					opp-160000000 {
> > +						opp-hz = /bits/ 64 <160000000>;
> > +						required-opps = <&rpmhpd_opp_low_svs>;
> > +					};
> Downstream seems to use 19200000 here

Ack, will update.

Thx,
Neil

> Otherwise,
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
>
> Konrad
>
> > +
> > +					opp-270000000 {
> > +						opp-hz = /bits/ 64 <270000000>;
> > +						required-opps = <&rpmhpd_opp_svs>;
> > +					};
> > +
> > +					opp-540000000 {
> > +						opp-hz = /bits/ 64 <540000000>;
> > +						required-opps = <&rpmhpd_opp_svs_l1>;
> > +					};
> > +
> > +					opp-810000000 {
> > +						opp-hz = /bits/ 64 <810000000>;
> > +						required-opps = <&rpmhpd_opp_nom>;
> > +					};
> > +				};
> > +			};
> > +
> >   			mdss_dsi0: dsi@ae94000 {
> >   				compatible = "qcom,sm8450-dsi-ctrl", "qcom,mdss-dsi-ctrl";
> >   				reg = <0 0x0ae94000 0 0x400>;