Re: [PATCH V2] dt-bindings: leds: add "usbport" trigger

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 08 Mar 2023, Rafał Miłecki wrote:

> From: Rafał Miłecki <rafal@xxxxxxxxxx>
>
> Linux's "usbport" trigger is a bit specific one. It allows LED to follow
> state of multiple USB ports which have to be selected additionally
> (there isn't a single trigger for each port).
>
> Default list of USB ports to monitor can be specified using
> "trigger-sources" DT property. Theoretically it should be possible for
> Linux to deduce applicable trigger based on the references nodes in the
> "trigger-sources". It hasn't been implemented however (probably due to
> laziness).
>
> Milk spilled - we already have DT files specifying "usbport" manually -
> allow that value in the binding. This fixes validation of in-kernel and
> external DT files.
>
> Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/leds/common.yaml | 1 +
>  1 file changed, 1 insertion(+)

Doesn't apply.  Please rebase onto -next.

Hint: Requires a line of documentation above the new property.

> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> index 15e3f6645682..95b316ee3146 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -99,6 +99,7 @@ properties:
>            - pattern
>            - usb-gadget
>            - usb-host
> +          - usbport
>        - pattern: "^cpu[0-9]*$"
>        - pattern: "^hci[0-9]+-power$"
>          # LED is triggered by Bluetooth activity
> --
> 2.34.1
>

--
Lee Jones [李琼斯]



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux