On 13/03/2023 17:56, Andrew Halaney wrote: > From: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> > > Convert Qualcomm ETHQOS Ethernet devicetree binding to YAML. > (...) > diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > new file mode 100644 > index 000000000000..68ef43fb283d > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > @@ -0,0 +1,112 @@ > +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/qcom,ethqos.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Ethernet ETHQOS device > + > +maintainers: > + - Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> > + > +description: > + This binding describes the dwmmac based Qualcomm ethernet devices which Drio "This binding describes", but say what is the hardware here. > + support Gigabit ethernet (version v2.3.0 onwards). > + > + So, this file documents platform glue layer for dwmmac stmmac based Qualcomm > + ethernet devices. > + > +allOf: > + - $ref: snps,dwmac.yaml# > + > +properties: > + compatible: > + enum: > + - qcom,qcs404-ethqos > + - qcom,sm8150-ethqos > + > + reg: > + maxItems: 2 > + > + reg-names: > + items: > + - const: stmmaceth > + - const: rgmii > + > + interrupts: > + items: > + - description: Combined signal for various interrupt events > + - description: The interrupt that occurs when Rx exits the LPI state > + > + interrupt-names: > + items: > + - const: macirq > + - const: eth_lpi > + > + clocks: > + maxItems: 4 > + > + clock-names: > + items: > + - const: stmmaceth > + - const: pclk > + - const: ptp_ref > + - const: rgmii > + > + iommus: > + maxItems: 1 Isn't this new property? Last time I asked to mention the changes to the binding done during conversion. Explain shortly why you are adding new properties. > + > +required: > + - compatible > + - clocks > + - clock-names reg-names > + > +unevaluatedProperties: false > + Best regards, Krzysztof
