On Wed, 2023-03-15 at 08:16 +0100, Krzysztof Kozlowski wrote:
> On 15/03/2023 04:45, Nancy Lin (林欣螢) wrote:
>
> Trim the replies and remove unneeded context. You want to get the
> attention of other people, not force them to read entire email.
>
> > > + mediatek,gce-client-reg:>> + $ref:
> > > /schemas/types.yaml#/definitions/phandle-array
> > > + description: The register of display function block to be
> > > set by
> > > gce.
> > > + There are 4 arguments in this property, gce node, subsys
> > > id,
> > > offset and
> > > + register size. The subsys id is defined in the gce header
> > > of
> > > each chips
> > > + include/dt-bindings/gce/<chip>-gce.h, mapping to the
> > > register
> > > of display
> > > + function block.
> > > + items:
> > > + items:
> > > + - description: phandle of GCE
> > > + - description: GCE subsys id
> > > + - description: register offset
> > > + - description: register size
> > > + minItems: 7
> > > + maxItems: 7
> > > +
> >
> > Hi Rob and krzysztof,
> >
> > I got the two messages when running dt_binding_check [1]. This
> > binding
> > patch was sent previously in [2].
> >
> > If I remove the following items/minItems/maxItems in the
> > mediatek,gce-
> > client property, the two message disappear. I don't know what's
> > wrong
> > with the original syntax. Do you have any suggestions for this?
> >
> > - items:
> > - items:
> > - - description: phandle of GCE
> > - - description: GCE subsys id
> > - - description: register offset
> > - - description: register size
> > - minItems: 7
> > - maxItems: 7
> >
> >
> > [1].
> > Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.e
> > xamp
> > le.dtb
> > /proj/mtk19347/cros/src/third_party/kernel/v5.10/Documentation/devi
> > cetr
> > ee/bindings/display/mediatek/mediatek,ethdr.example.dtb:
> > hdr-engine@1c114000: mediatek,gce-client-reg:0: [4294967295, 7,
> > 16384,
> > 4096, 4294967295, 7, 20480, 4096, 4294967295, 7, 28672, 4096,
> > 4294967295, 7, 36864, 4096, 4294967295, 7, 40960, 4096, 4294967295,
> > 7,
> > 45056, 4096, 4294967295, 7, 49152, 4096] is too long
> > From schema:
>
> This looks like known issue with phandles with variable number of
> arguments. Either we add it to the exceptions or just define it in
> reduced way like in other cases - only maxItems: 1 without describing
> items.
>
>
> Best regards,
> Krzysztof
Hi Krzysztof,
Thanks for the comment.
But I have several items for this vendor property in the binding
example.
Can I remove maxItems? Change the mediatek,gce-client-reg as [1].
[1]
mediatek,gce-client-reg:
$ref: /schemas/types.yaml#/definitions/phandle-array
description: The register of display function block to be set by
gce.
There are 4 arguments in this property, gce node, subsys id,
offset and
register size. The subsys id is defined in the gce header of each
chips
include/dt-bindings/gce/<chip>-gce.h, mapping to the register of
display
function block.
Regards,
Nancy
>
