On Wed, Mar 15, 2023 at 05:06:04PM -0700, Doug Anderson wrote:
> Hi,
>
> On Wed, Mar 15, 2023 at 9:12 AM Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:
> >
> >
> >
> > On 15.03.2023 16:43, Nikita Travkin wrote:
> > > lpass clocks are usually blocked from HLOS by the firmware and
> > > instead are managed by the ADSP. Mark them as reserved and explicitly
> > > enable in the CrOS boards that have special, cooperative firmware.
> > >
> > > Signed-off-by: Nikita Travkin <nikita@xxxxxxx>
> > > ---
> > +CC Doug
> >
> > Please confirm whether this also applies to IDP (in which case
> > this would have been a bugfix).
>
> Thanks for the CC! Actually, Judy (and maybe Matthias) might be
> better. The audio stuff makes my head spin a little bit and I know
> they've kept track of it much better than I have. If they don't have
> time, I can dig more into it myself. I also added Srinivasa just in
> case.
>
> In general, though, I think people at Google don't interact with IDP
> very much. It's a reference board from Qualcomm and not the right form
> factor. It also doesn't support most of the tooling that folks at
> Google on the ChromeOS team expect. I don't know if audio was ever
> really supported on IDP. Probably not since there's no "sound" node in
> the IDP device tree file.
I don't know about the history of audio on the IDP either, I share Doug's
assessment that it looks like it was never supported.
> > Konrad
> > > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 8 ++++++++
> > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 ++++
> > > 2 files changed, 12 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> > > index 423630c4d02c..26def6e12723 100644
> > > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> > > @@ -785,6 +785,14 @@ alc5682: codec@1a {
> > > };
> > > };
> > >
> > > +&lpasscc {
> > > + status = "okay";
> > > +};
> > > +
> > > +&lpass_hm {
> > > + status = "okay";
> > > +};
> > > +
> > > &lpass_cpu {
> > > status = "okay";
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > > index 53f0076f20f6..f0de177981f9 100644
> > > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > > @@ -3623,6 +3623,8 @@ lpasscc: clock-controller@62d00000 {
> > > power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>;
> > > #clock-cells = <1>;
> > > #power-domain-cells = <1>;
> > > +
> > > + status = "reserved"; /* Controlled by ADSP */
> > > };
> > >
> > > lpass_cpu: lpass@62d87000 {
> > > @@ -3671,6 +3673,8 @@ lpass_hm: clock-controller@63000000 {
> > >
> > > #clock-cells = <1>;
> > > #power-domain-cells = <1>;
> > > +
> > > + status = "reserved"; /* Controlled by ADSP */
> > > };
> > > };
> > >
