On 15/03/2023 11:13, Konrad Dybcio wrote: >>> } >>> >>> static int bwmon_probe(struct platform_device *pdev) >>> @@ -645,6 +816,21 @@ static const struct icc_bwmon_data msm8998_bwmon_data = { >>> .quirks = BWMON_HAS_GLOBAL_IRQ, >>> .regmap_fields = msm8998_bwmon_reg_fields, >>> .regmap_cfg = &msm8998_bwmon_regmap_cfg, >>> + .global_regmap_fields = msm8998_bwmon_global_reg_fields, >>> + .global_regmap_cfg = &msm8998_bwmon_global_regmap_cfg, >>> +}; >>> + >>> +static const struct icc_bwmon_data sdm845_ddr_bwmon_data = { >> >> The name "ddr" is here (and other places) confusing. This is not the DDR >> bwmon. > I suppose cpu_bwmon could make more sense? Yes, we keep calling it CPU. Best regards, Krzysztof