Maybe "oneOf" should be added at least ? compatible: oneOf: - enum: Regards, Alex Le mer. 15 mars 2023 à 09:01, Alexandre Mergnat <amergnat@xxxxxxxxxxxx> a écrit : > > Le ven. 10 mars 2023 à 09:39, Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> a écrit : > > > > On 09/03/2023 15:23, Alexandre Mergnat wrote: > > > Add compatible for the MT8365 SoC. > > > > > > Signed-off-by: Alexandre Mergnat <amergnat@xxxxxxxxxxxx> > > > --- > > > Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml > > > index ca0ca549257d..931d66893dff 100644 > > > --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml > > > +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml > > > @@ -34,6 +34,7 @@ properties: > > > - mediatek,mt8186-mdp3-mutex > > > - mediatek,mt8192-disp-mutex > > > - mediatek,mt8195-disp-mutex > > > + - mediatek,mt8365-disp-mutex > > > > All these look compatible. Either make mt8635 compatible with something > > or even rework entire list and make everything compatible. > > All of them use "mtk_mutec.c" but have specific data. > > .data = &mt8173_mutex_driver_data}, > { .compatible = "mediatek,mt8183-disp-mutex", > .data = &mt8183_mutex_driver_data}, > { .compatible = "mediatek,mt8186-disp-mutex", > .data = &mt8186_mutex_driver_data}, > { .compatible = "mediatek,mt8186-mdp3-mutex", > .data = &mt8186_mdp_mutex_driver_data}, > { .compatible = "mediatek,mt8192-disp-mutex", > .data = &mt8192_mutex_driver_data}, > { .compatible = "mediatek,mt8195-disp-mutex", > .data = &mt8195_mutex_driver_data}, > { .compatible = "mediatek,mt8365-disp-mutex", > .data = &mt8365_mutex_driver_data}, > > I don't see any SoC compatible with mt8635, and I have no idea which > rework you have in mind. Can you please point me an example ? > > Thanks > Alex