Hi Andrew, Many thanks for the review. >> +++ b/Documentation/devicetree/bindings/soc/pistachio/img-efuse.txt >> @@ -0,0 +1,18 @@ >> +* IMG Pistachio eFuse controller >> + >> +Required properties: >> +- compatible: Must be "img,pistachio-efuse". >> +- reg: Must contain the base address and length of the eFuse registers. >> +- clocks: Must contain an entry for each entry in clock-names. >> + See ../clock/clock-bindings.txt for details. >> +- clock-names: Must include the following entries: >> + - efuse: External oscillator clock > How is the external oscillator related to efuse? Also, perhaps it > should be called "osc" since it's not an efuse-specific clock. This is what I read from the eFuse Controller TRM (Generic eFuse Controller.Technical Reference Manual.pdf) with respect to this clock. "Free-running oscillator clock – used to clock the fuse-unload state machine. < 50Mhz" Please comment. >> + - sys: eFuse system interface clock > I don't see a system interface gate clock for efuse in the TRM ... This is what I read from the above document about the sys_clk. "System bus clock, synchronous to the IMGBus1 input. < 400 MHz." I think this clock enables access to shadow RAM where the eFuses status is stored. Please comment. regards, Naidu. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
