On Tue, Mar 14, 2023 at 01:34:40PM +0100, Martin Zaťovič wrote: > Thank you for the code review Andy! I'm not sure why you mentioned this in the reply to kernel build bot message. > Regarding the OF only code - I have been told, that implementing my own ID > table > so that a device can be added from another driver is no longer the way to > go. > The only other option I can think of is ACPI device enumeration, which I > did not > implement as I really believe that Wiegand will only be used on embedded > devices. > > Despite that I respect the message - the code should be agnostic and count > with > every option so I will add ACPI support. Is there any other way of > instantiating > devices I am not aware of? This is also seems to me unrelated to this message. Can you reply to the correct message with enough context, please? > st 1. 3. 2023 o 23:53 kernel test robot <lkp@xxxxxxxxx> napísal(a): > > > Hi Martin, > > > > I love your patch! Yet something to improve: > > > > [auto build test ERROR on robh/for-next] > > [also build test ERROR on linus/master v6.2 next-20230301] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > url: > > https://github.com/intel-lab-lkp/linux/commits/Martin-Za-ovi/dt-bindings-wiegand-add-Wiegand-controller-common-properties/20230301-223030 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git > > for-next > > patch link: > > https://lore.kernel.org/r/20230301142835.19614-3-m.zatovic1%40gmail.com > > patch subject: [PATCHv3 2/4] wiegand: add Wiegand bus driver > > config: sh-allmodconfig ( > > https://download.01.org/0day-ci/archive/20230302/202303020615.0F00suDa-lkp@xxxxxxxxx/config > > ) > > compiler: sh4-linux-gcc (GCC) 12.1.0 > > reproduce (this is a W=1 build): > > wget > > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross > > -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # > > https://github.com/intel-lab-lkp/linux/commit/c62b833f42989e355d82cd20b7803e0228e33792 > > git remote add linux-review https://github.com/intel-lab-lkp/linux > > git fetch --no-tags linux-review > > Martin-Za-ovi/dt-bindings-wiegand-add-Wiegand-controller-common-properties/20230301-223030 > > git checkout c62b833f42989e355d82cd20b7803e0228e33792 > > # save the config file > > mkdir build_dir && cp config build_dir/.config > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross > > W=1 O=build_dir ARCH=sh olddefconfig > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross > > W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/wiegand/ > > > > If you fix the issue, kindly add following tag where applicable > > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > > | Link: > > https://lore.kernel.org/oe-kbuild-all/202303020615.0F00suDa-lkp@xxxxxxxxx/ > > > > All errors (new ones prefixed by >>): > > > > >> drivers/wiegand/wiegand.c:441:27: error: initialization of 'void > > (*)(struct device *)' from incompatible pointer type 'int (*)(struct device > > *)' [-Werror=incompatible-pointer-types] > > 441 | .remove = wiegand_remove, > > | ^~~~~~~~~~~~~~ > > drivers/wiegand/wiegand.c:441:27: note: (near initialization for > > 'wiegand_bus_type.remove') > > cc1: some warnings being treated as errors > > > > > > vim +441 drivers/wiegand/wiegand.c > > > > 436 > > 437 static struct bus_type wiegand_bus_type = { > > 438 .name = "wiegand", > > 439 .match = wiegand_match_device, > > 440 .probe = wiegand_probe, > > > 441 .remove = wiegand_remove, > > 442 }; > > 443 > > > > -- > > 0-DAY CI Kernel Test Service > > https://github.com/intel/lkp-tests > > -- With Best Regards, Andy Shevchenko
