Rob Herring <robh@xxxxxxxxxx> :
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties.
> Convert reading boolean properties to to of_property_read_bool().
>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
[...]
> drivers/net/ethernet/via/via-velocity.c | 3 +--
[...]
> diff --git a/drivers/net/ethernet/via/via-velocity.c b/drivers/net/ethernet/via/via-velocity.c
> index a502812ac418..86f7843b4591 100644
> --- a/drivers/net/ethernet/via/via-velocity.c
> +++ b/drivers/net/ethernet/via/via-velocity.c
> @@ -2709,8 +2709,7 @@ static int velocity_get_platform_info(struct velocity_info *vptr)
> struct resource res;
> int ret;
>
> - if (of_get_property(vptr->dev->of_node, "no-eeprom", NULL))
> - vptr->no_eeprom = 1;
> + vptr->no_eeprom = of_property_read_bool(vptr->dev->of_node, "no-eeprom");
>
> ret = of_address_to_resource(vptr->dev->of_node, 0, &res);
> if (ret) {
Acked-by: Francois Romieu <romieu@xxxxxxxxxxxxx>
Simon Horman's comment regarding assignment of bool value to an integer
typed field also apply here.
--
Ueimor
