On Sun, 12 Mar 2023 22:02:24 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:
> On 12/03/2023 21:52, Andreas Kemnade wrote:
> > This adds a devicetree for the Kobo Aura 2 Ebook reader. It is based
> > on boards marked with "37NB-E60Q30+4A3". It is equipped with an i.MX6SL
> > SoC.
> >
>
> Thank you for your patch. There is something to discuss/improve.
[...]
> > + pinctrl_i2c2: i2c2grp {
> > + fsl,pins = <
> > + MX6SL_PAD_I2C2_SCL__I2C2_SCL 0x4001f8b1
> > + MX6SL_PAD_I2C2_SDA__I2C2_SDA 0x4001f8b1
> > + >;
> > + };
> > +
> > + pinctrl_i2c2_sleep: i2c2grp-sleep {
>
> Shouldn't all groups end with 'grp' suffix? Are you sure this passes
> dtbs_check?
>
> ...
>
No problem with dtbs_check. But I will resend with corrected names.
Regards,
Andreas
