On 27/02/2023 20:38, Henrik Grimler wrote:
> Previously, the mshc0 alias has been necessary so that
> MMC_CAP_1_8V_DDR | MMC_CAP_8_BIT_DATA are set for mshc_0/mmc_0.
> However, these capabilities should be described in the device tree so
> that we do not have to rely on the alias.
>
> The property mmc-ddr-1_8v replaces MMC_CAP_1_8V_DDR, while bus_width =
> <8>, which is already set for all the mshc0/mmc0 nodes, replaces
> MMC_CAP_8_BIT_DATA.
>
> Also cleanup and sort (but keep status property at top) some of the
status is rather the last property
> nodes while we are modifying them.
Don't mix cleanups with any other changes.
>
> Signed-off-by: Henrik Grimler <henrik@xxxxxxxxxx>
> ---
> Changes since v2:
> * Set mmc-ddr-1_8v in device trees for mshc_0/mmc_0
>
> arch/arm/boot/dts/exynos3250-artik5.dtsi | 15 ++++++-------
> arch/arm/boot/dts/exynos3250-monk.dts | 19 ++++++++---------
> arch/arm/boot/dts/exynos3250-rinato.dts | 21 ++++++++-----------
> arch/arm/boot/dts/exynos3250.dtsi | 3 ---
> arch/arm/boot/dts/exynos4210-i9100.dts | 5 ++---
> arch/arm/boot/dts/exynos4210-origen.dts | 3 ++-
> arch/arm/boot/dts/exynos4210-trats.dts | 3 ++-
> .../boot/dts/exynos4210-universal_c210.dts | 3 ++-
> arch/arm/boot/dts/exynos4412-itop-elite.dts | 4 ++++
> .../boot/dts/exynos4412-itop-scp-core.dtsi | 17 +++++++++------
> arch/arm/boot/dts/exynos4412-midas.dtsi | 17 ++++++++-------
> .../boot/dts/exynos4412-odroid-common.dtsi | 16 +++++++-------
> arch/arm/boot/dts/exynos4412-origen.dts | 12 +++++------
> arch/arm/boot/dts/exynos4412-p4note.dtsi | 17 ++++++++-------
> arch/arm/boot/dts/exynos4412.dtsi | 1 -
> arch/arm/boot/dts/exynos5250-arndale.dts | 1 +
> arch/arm/boot/dts/exynos5250-smdk5250.dts | 1 +
> arch/arm/boot/dts/exynos5250-snow-common.dtsi | 1 +
> arch/arm/boot/dts/exynos5250-spring.dts | 1 +
> arch/arm/boot/dts/exynos5250.dtsi | 4 ----
> arch/arm/boot/dts/exynos5260-xyref5260.dts | 11 +++++-----
> arch/arm/boot/dts/exynos5410-odroidxu.dts | 1 +
> arch/arm/boot/dts/exynos5410-smdk5410.dts | 1 +
> arch/arm/boot/dts/exynos5420-arndale-octa.dts | 1 +
> .../dts/exynos5420-galaxy-tab-common.dtsi | 1 +
> arch/arm/boot/dts/exynos5420-peach-pit.dts | 1 +
> arch/arm/boot/dts/exynos5420-smdk5420.dts | 1 +
> arch/arm/boot/dts/exynos5420.dtsi | 3 ---
> .../boot/dts/exynos5422-odroidxu3-common.dtsi | 1 +
> arch/arm/boot/dts/exynos5422-samsung-k3g.dts | 1 +
> arch/arm/boot/dts/exynos5800-peach-pi.dts | 1 +
> 31 files changed, 100 insertions(+), 87 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos3250-artik5.dtsi b/arch/arm/boot/dts/exynos3250-artik5.dtsi
> index 0ac3f284fbb8..794cbf579316 100644
> --- a/arch/arm/boot/dts/exynos3250-artik5.dtsi
> +++ b/arch/arm/boot/dts/exynos3250-artik5.dtsi
> @@ -315,19 +315,20 @@ buck5_reg: BUCK5 {
> };
>
> &mshc_0 {
> - non-removable;
> + status = "okay";> + bus-width = <8>;
> cap-mmc-highspeed;
> card-detect-delay = <200>;
> - vmmc-supply = <&ldo12_reg>;
> clock-frequency = <100000000>;
> max-frequency = <100000000>;
> + mmc-ddr-1_8v;
> + non-removable;
> + pinctrl-0 = <&sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8>;
> + pinctrl-names = "default";
> samsung,dw-mshc-ciu-div = <1>;
> - samsung,dw-mshc-sdr-timing = <0 1>;
> samsung,dw-mshc-ddr-timing = <1 2>;
> - pinctrl-names = "default";
> - pinctrl-0 = <&sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8>;
> - bus-width = <8>;
> - status = "okay";
> + samsung,dw-mshc-sdr-timing = <0 1>;
> + vmmc-supply = <&ldo12_reg>;
It is impossible to review what happenned here.
Best regards,
Krzysztof
