Acked-by: Guo Ren <guoren@xxxxxxxxxx> (csky) On Fri, Mar 10, 2023 at 10:48 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > It is preferred to use typed property access functions (i.e. > of_property_read_<type> functions) rather than low-level > of_get_property/of_find_property functions for reading properties. > Convert reading boolean properties to to of_property_read_bool(). > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > --- > drivers/irqchip/irq-csky-apb-intc.c | 2 +- > drivers/irqchip/irq-gic-v2m.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/irqchip/irq-csky-apb-intc.c b/drivers/irqchip/irq-csky-apb-intc.c > index 42d8a2438ebc..6710691e4c25 100644 > --- a/drivers/irqchip/irq-csky-apb-intc.c > +++ b/drivers/irqchip/irq-csky-apb-intc.c > @@ -68,7 +68,7 @@ static void __init ck_set_gc(struct device_node *node, void __iomem *reg_base, > gc->chip_types[0].chip.irq_mask = irq_gc_mask_clr_bit; > gc->chip_types[0].chip.irq_unmask = irq_gc_mask_set_bit; > > - if (of_find_property(node, "csky,support-pulse-signal", NULL)) > + if (of_property_read_bool(node, "csky,support-pulse-signal")) > gc->chip_types[0].chip.irq_unmask = irq_ck_mask_set_bit; > } > > diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c > index f1e75b35a52a..f2ff4387870d 100644 > --- a/drivers/irqchip/irq-gic-v2m.c > +++ b/drivers/irqchip/irq-gic-v2m.c > @@ -421,7 +421,7 @@ static int __init gicv2m_of_init(struct fwnode_handle *parent_handle, > u32 spi_start = 0, nr_spis = 0; > struct resource res; > > - if (!of_find_property(child, "msi-controller", NULL)) > + if (!of_property_read_bool(child, "msi-controller")) > continue; > > ret = of_address_to_resource(child, 0, &res); > -- > 2.39.2 > -- Best Regards Guo Ren