On 11/03/2023 14:46, Jan Jasper de Kroon wrote: Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching). Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. > This patch adds a new property, 'hold-in-reset-in-suspend', to the Goodix touchscreen > device tree binding. When set to true, the touchscreen controller will be held in > reset mode during system suspend, reducing power consumption. The property is optional > and defaults to false if not present. > > I am submitting this patch to the Device Tree mailing list to add a new property to > the Goodix touchscreen device tree binding. This patch supplements a related patch > sent to the linux-input mailing list, which updates the Goodix touchscreen driver to Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > use this new property. > The linux-input patch can be found at: > https://lore.kernel.org/all/20230311131534.484700-1-jajadekroon@xxxxxxxxx/ > > Signed-off-by: Jan Jasper de Kroon <jajadekroon@xxxxxxxxx> > --- > .../devicetree/bindings/input/touchscreen/goodix.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml > index 3d016b87c8df..a7c3d6b5156a 100644 > --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml > +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml > @@ -56,6 +56,14 @@ properties: > touchscreen-size-y: true > touchscreen-swapped-x-y: true > > + hold-in-reset-in-suspend: > + type: boolean > + description: | > + When set to true, the touchscreen controller will be held in reset mode > + during system suspend. This can help reduce power consumption, but may > + cause the touchscreen to take longer to resume when the system is woken > + up from suspend. Defaults to false if not present. > + > additionalProperties: false > > required: > @@ -75,6 +83,7 @@ examples: > interrupts = <0 0>; > irq-gpios = <&gpio1 0 0>; > reset-gpios = <&gpio1 1 0>; > + hold-in-reset-in-suspend = <true>; Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Best regards, Krzysztof
