On Mon, 6 Mar 2023 at 22:27, Sean Anderson <sean.anderson@xxxxxxxx> wrote: > > On 3/6/23 15:51, Jonas Gorski wrote: > > Hi, > > > > On Mon, 6 Mar 2023 at 20:16, Sean Anderson <sean.anderson@xxxxxxxx> wrote: > >> > >> This is a generic binding for simple MMIO GPIO controllers. Although we > >> have a single driver for these controllers, they were previously spread > >> over several files. Consolidate them. The register descriptions are > >> adapted from the comments in the source. There is no set order for the > >> registers, so I have not specified one. > >> > >> Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxx> > >> --- > >> > >> Changes in v10: > >> - New > >> > >> .../bindings/gpio/brcm,bcm6345-gpio.yaml | 16 +-- > >> .../devicetree/bindings/gpio/gpio-mmio.yaml | 136 ++++++++++++++++++ > >> .../bindings/gpio/ni,169445-nand-gpio.txt | 38 ----- > >> .../devicetree/bindings/gpio/wd,mbl-gpio.txt | 38 ----- > >> 4 files changed, 137 insertions(+), 91 deletions(-) > >> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-mmio.yaml > >> delete mode 100644 Documentation/devicetree/bindings/gpio/ni,169445-nand-gpio.txt > >> delete mode 100644 Documentation/devicetree/bindings/gpio/wd,mbl-gpio.txt > >> > >> diff --git a/Documentation/devicetree/bindings/gpio/brcm,bcm6345-gpio.yaml b/Documentation/devicetree/bindings/gpio/brcm,bcm6345-gpio.yaml > >> index 4d69f79df859..e11f4af49c52 100644 > >> --- a/Documentation/devicetree/bindings/gpio/brcm,bcm6345-gpio.yaml > >> +++ b/Documentation/devicetree/bindings/gpio/brcm,bcm6345-gpio.yaml > > > > You are (re-)moving the compatible this file is named after, you might > > want to rename the file as well then. Going by age bcm6358 would be > > the next oldest one (bcm6318 would be the newest, despite the lowest > > number). > > I can do that. Would it be fine to rename to e.g. brcm,bcm63xx-gpio.yaml? I'm not up to date with current naming policies (if there are any at all), but looking at what's currently there this should be fine. Jonas
