Hello Krzysztof,
On 10/03/23 14:59, Krzysztof Kozlowski wrote:
> On 10/03/2023 10:28, Siddharth Vadapalli wrote:
>> The J7 Quad Port Add-On Ethernet Card for J721E Common-Proc-Board supports
>> QSGMII mode. Use the overlay to configure CPSW9G ports in QSGMII mode.
>>
>> Add support to reset the PHY from kernel by using gpio-hog and gpio-reset.
>>
>> Add aliases for CPSW9G ports to enable kernel to fetch MAC addresses
>> directly from U-Boot.
>>
>
>
>> +&exp2 {
>> + qsgmii-line-hog {
>> + gpio-hog;
>> + gpios = <16 GPIO_ACTIVE_HIGH>;
>> + output-low;
>> + line-name = "qsgmii-pwrdn-line";
>> + };
>> +};
>> +
>> +&main_pmx0 {
>> + mdio_pins_default: mdio_pins_default {
>
> No underscores in node names. Didn't you already get such comments?
Sorry, I overlooked this. I am aware that underscores shouldn't be used. I will
post the v2 series fixing this.
Regards,
Siddharth.
