On 07/03/2023 14:17, Alexandre Mergnat wrote: > This SoC is able to drive the following output current: > - 2 mA > - 4 mA > - 6 mA > - 8 mA > - 10 mA > - 12 mA > - 14 mA > - 16 mA > > Then drive-strength property is set with enum to reflect its HW capability. > > Signed-off-by: Alexandre Mergnat <amergnat@xxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml > index 4b96884a1afc..101871ec6693 100644 > --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml > @@ -79,6 +79,9 @@ patternProperties: > > bias-pull-down: true > > + drive-strength: > + enum: [2, 4, 6, 8, 10, 12, 14, 16] Isn't this conflicting with mediatek,drive-strength-adv? Your commit msg suggests you add a missing property, but I would say nothing was missing here. You need review from (pinctrl) Mediatek maintainers how the bindings for all Mediateks are organized. Best regards, Krzysztof