Hi Sebastian,
thanks for your patches!
On Thu, Mar 9, 2023 at 11:50 PM Sebastian Reichel <sre@xxxxxxxxxx> wrote:
> Add binding for a battery that is only monitored via ADC
> channels and simple status GPIOs.
>
> Signed-off-by: Sebastian Reichel <sre@xxxxxxxxxx>
This does look very useful.
> +title: ADC battery
> +
> +maintainers:
> + - Sebastian Reichel <sre@xxxxxxxxxx>
> +
> +description: |
> + Basic Battery, which only reports (in circuit) voltage and optionally
> + current via an ADC channel.
I would over-specify: "voltage over the terminals" and
"current out of the battery" so this cannot be misunderstood.
+ this text:
It can also optionally indicate that the battery is full by pulling a GPIO
line.
> + charged-gpios:
> + description:
> + GPIO which signals that the battery is fully charged.
It doesn't say how, I guess either this is an analog circuit (!) or
a charger IC? If it doesn't matter, no big deal, but if something is
implicit here, then spell it out please.
> + fuel-gauge {
This techno-lingo/slang term is a bit unfortunate, but if there are
precedents then stick with it.
The correct term could be something like battery-capacity-meter
I suppose.
Yours,
Linus Walleij
