Re: [PATCH V2] dt-bindings: nvmem: layouts: add fixed-layout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9.03.2023 14:07, Michael Walle wrote:
Am 2023-03-09 12:39, schrieb Rafał Miłecki:
From: Rafał Miłecki <rafal@xxxxxxxxxx>

With the introduction of NVMEM layouts we should prefer and support
describing all NVMEM devices content in the "nvmem-layout" node. That
inludes using it for fixed NVMEM cells (those with hardcoded offset &
size).

This seems to be cleaner design and more explicit.

Introduce a binding allowing fixed NVMEM cells as a type of layout. To
avoid code duplication put shared part in the fixed-cell.yaml.

Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>

I don't feel comfortable to add an acked-by or reviewed-by here
because I don't do much with dt-bindings myself, but this looks
good to me.

Thank you!


 From a device tree binding POV, could there be a

nvmem-layout@0 {
   reg = <0>;
   compatible = "layout1";
};

nvmem-layout@1000 {
   reg = <1000>;
   compatible = "layout2";
};

for partitioned eeproms for example?

Maybe. Could you send a patch adding such binding with a proper
explanation what devices need it, please? It's out of scope of this
patch.



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux