Hi Köry, I love your patch! Perhaps something to improve: [auto build test WARNING on v6.2] [cannot apply to robh/for-next horms-ipvs/master net/master net-next/master linus/master v6.3-rc1 next-20230309] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/K-ry-Maincent/net-ethtool-Refactor-identical-get_ts_info-implementations/20230308-220453 patch link: https://lore.kernel.org/r/20230308135936.761794-4-kory.maincent%40bootlin.com patch subject: [PATCH v3 3/5] net: Let the active time stamping layer be selectable. config: x86_64-randconfig-a003 (https://download.01.org/0day-ci/archive/20230310/202303100154.iqj4R4fL-lkp@xxxxxxxxx/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/d81a36f239360e7e3b9ca2633e52b3cb12205590 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review K-ry-Maincent/net-ethtool-Refactor-identical-get_ts_info-implementations/20230308-220453 git checkout d81a36f239360e7e3b9ca2633e52b3cb12205590 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/phy/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303100154.iqj4R4fL-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> drivers/net/phy/phy_device.c:1384:6: warning: no previous prototype for function 'of_set_timestamp' [-Wmissing-prototypes] void of_set_timestamp(struct net_device *netdev, struct phy_device *phydev) ^ drivers/net/phy/phy_device.c:1384:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void of_set_timestamp(struct net_device *netdev, struct phy_device *phydev) ^ static 1 warning generated. vim +/of_set_timestamp +1384 drivers/net/phy/phy_device.c 1383 > 1384 void of_set_timestamp(struct net_device *netdev, struct phy_device *phydev) 1385 { 1386 struct device_node *node = phydev->mdio.dev.of_node; 1387 const struct ethtool_ops *ops = netdev->ethtool_ops; 1388 const char *s; 1389 enum timestamping_layer ts_layer = 0; 1390 1391 if (phy_has_hwtstamp(phydev)) 1392 ts_layer = PHY_TIMESTAMPING; 1393 else if (ops->get_ts_info) 1394 ts_layer = MAC_TIMESTAMPING; 1395 1396 if (of_property_read_string(node, "preferred-timestamp", &s)) 1397 goto out; 1398 1399 if (!s) 1400 goto out; 1401 1402 if (phy_has_hwtstamp(phydev) && !strcmp(s, "phy")) 1403 ts_layer = PHY_TIMESTAMPING; 1404 1405 if (ops->get_ts_info && !strcmp(s, "mac")) 1406 ts_layer = MAC_TIMESTAMPING; 1407 1408 out: 1409 netdev->selected_timestamping_layer = ts_layer; 1410 } 1411 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
