Hi Sam,
On 09.03.2023 00:09, Sam Protsenko wrote:
> Power Domains in Exynos850 are not really different from other Exynos
> platforms. Enabling Exynos850 support in the PD driver is really just a
> matter of adding:
>
> static const struct exynos_pm_domain_config exynos850_cfg = {
> .local_pwr_cfg = 0x1,
> };
>
> to the driver. But in the face of recent developments, e.g. this patch:
>
> arm64: dts: exynos: move MIPI phy to PMU node in Exynos5433
>
> it looked logical to rework the PD driver a bit to support its nesting
> under the PMU node, while adding Exynos850 support to it. Initially I
> only wanted to add syscon regmap support via some dedicated property,
> but pulling PD nodes under the PMU syscon looks like more correct way.
Frankly speaking if you are changing this, you can go even further.
Simply make PMU node a PM domain provider and specify the power domain
as a phandle parameter. This is how it should have been done from the
beginning, but for some unknown reasons wasn't. There is really no need
to have a separate node for each power domain. This will also move
implementation details to the PMU / power domain drivers and it will
make it much easier to extend/modify it in the future. IMHO same applies
for PHY nodes.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
