On 09/03/2023 04:18, zhuyinbo wrote: > > 在 2023/3/9 上午10:58, zhuyinbo 写道: >> >> 在 2023/3/8 下午8:16, kernel test robot 写道: >>> Hi Yinbo, >>> >>> I love your patch! Yet something to improve: >>> >>> [auto build test ERROR on clk/clk-next] >>> [also build test ERROR on robh/for-next linus/master v6.3-rc1 >>> next-20230308] >>> [If your patch is applied to the wrong git tree, kindly drop us a note. >>> And when submitting patch, we suggest to use '--base' as documented in >>> https://git-scm.com/docs/git-format-patch#_base_tree_information] >>> >>> url: >>> https://github.com/intel-lab-lkp/linux/commits/Yinbo-Zhu/clk-clk-loongson2-add-clock-controller-driver-support/20230307-195252 >>> base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git >>> clk-next >>> patch link: >>> https://lore.kernel.org/r/20230307115022.12846-2-zhuyinbo%40loongson.cn >>> patch subject: [PATCH v13 2/2] clk: clk-loongson2: add clock >>> controller driver support >>> config: mips-allyesconfig >>> (https://download.01.org/0day-ci/archive/20230308/202303082037.QPfBP64A-lkp@xxxxxxxxx/config) >>> compiler: mips-linux-gcc (GCC) 12.1.0 >>> reproduce (this is a W=1 build): >>> wget >>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross >>> -O ~/bin/make.cross >>> chmod +x ~/bin/make.cross >>> # >>> https://github.com/intel-lab-lkp/linux/commit/391d6fc63ac65f5456e4755c9dd85232a6296285 >>> git remote add linux-review >>> https://github.com/intel-lab-lkp/linux >>> git fetch --no-tags linux-review >>> Yinbo-Zhu/clk-clk-loongson2-add-clock-controller-driver-support/20230307-195252 >>> git checkout 391d6fc63ac65f5456e4755c9dd85232a6296285 >>> # save the config file >>> mkdir build_dir && cp config build_dir/.config >>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 >>> make.cross W=1 O=build_dir ARCH=mips olddefconfig >>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 >>> make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/ >>> >>> If you fix the issue, kindly add following tag where applicable >>> | Reported-by: kernel test robot <lkp@xxxxxxxxx> >>> | Link: >>> https://lore.kernel.org/oe-kbuild-all/202303082037.QPfBP64A-lkp@xxxxxxxxx/ >>> >>> All errors (new ones prefixed by >>): >>> >>> drivers/clk/clk-loongson2.c: In function 'loongson2_calc_pll_rate': >>>>> drivers/clk/clk-loongson2.c:79:15: error: implicit declaration of >>>>> function 'readq'; did you mean 'readl'? >>>>> [-Werror=implicit-function-declaration] >>> 79 | val = readq(loongson2_pll_base + offset); >>> | ^~~~~ >>> | readl >>> cc1: some warnings being treated as errors >> >> The CONFIG_64BIT not enabled in your config file, I will add a depend >> on "CONFIG_64BIT" in my clock driver to fix this compile error. > My clock is for LoongArch platform, The LOONGARCH had select > "CONFIG_64BIT", I will add a depend on "LOONGARCH" in my clock driver to > fix this compile error. No. Fix your code instead. Best regards, Krzysztof
