On Wed, 08 Mar 2023 20:14:50 +0000, Bogdan Ionescu wrote: > Hi all, > > This is my first patch to the kernel, so I expect to have made > some mistakes. I did my best to follow the documentation and > submitting patches guidelines, but if I missed something, please > let me know. > > I wasn't sure if I had to add myself to the MAINTAINERS file for such a > small patch, so I didn't. > > Patch begins here: > > Added devicetree bindings documentation for the rohm,bd65b60 > led driver. > > Signed-off-by: Bogdan Ionescu <bogdan.ionescu.work@xxxxxxxxx> > --- > .../bindings/leds/rohm,bd65b60-leds.yaml | 77 +++++++++++++++++++ > include/dt-bindings/leds/leds-bd65b60.h | 20 +++++ > 2 files changed, 97 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/rohm,bd65b60-leds.yaml > create mode 100644 include/dt-bindings/leds/leds-bd65b60.h > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/leds/rohm,bd65b60-leds.example.dts:25.17-30: Warning (reg_format): /example-0/i2c/led_controler@64:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) Documentation/devicetree/bindings/leds/rohm,bd65b60-leds.example.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/leds/rohm,bd65b60-leds.example.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/leds/rohm,bd65b60-leds.example.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/leds/rohm,bd65b60-leds.example.dts:21.13-35.11: Warning (i2c_bus_bridge): /example-0/i2c: incorrect #address-cells for I2C bus Documentation/devicetree/bindings/leds/rohm,bd65b60-leds.example.dts:21.13-35.11: Warning (i2c_bus_bridge): /example-0/i2c: incorrect #size-cells for I2C bus Documentation/devicetree/bindings/leds/rohm,bd65b60-leds.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/leds/rohm,bd65b60-leds.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'i2c_bus_bridge' Documentation/devicetree/bindings/leds/rohm,bd65b60-leds.example.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/leds/rohm,bd65b60-leds.example.dts:23.30-34.15: Warning (avoid_default_addr_size): /example-0/i2c/led_controler@64: Relying on default #address-cells value Documentation/devicetree/bindings/leds/rohm,bd65b60-leds.example.dts:23.30-34.15: Warning (avoid_default_addr_size): /example-0/i2c/led_controler@64: Relying on default #size-cells value Documentation/devicetree/bindings/leds/rohm,bd65b60-leds.example.dtb: Warning (unique_unit_address_if_enabled): Failed prerequisite 'avoid_default_addr_size' doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230308201451.11629-1-bogdan.ionescu.work@xxxxxxxxx The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
