On 08/03/2023 17:09, Vasily Khoruzhick wrote: > On Wed, Mar 8, 2023 at 3:31 AM Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml >>> index 35f74eda30ae..0813ad22dc76 100644 >>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml >>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml >>> @@ -201,6 +201,11 @@ properties: >>> - friendlyarm,nanopi-r4s-enterprise >>> - const: rockchip,rk3399 >>> >>> + - description: FriendlyElec NanoPi R5S board >>> + >> >> Does not look like ordered alphabetically. Are you sure this is correct >> place for it? > > Hmm, strictly speaking, "FriendlyElec NanoPi R5S board" should go in > between of "FriendlyElec NanoPi R2S" and "FriendlyElec NanoPi4 series > boards" if we want it in alphabetical order, not after "FriendlyElec > NanoPi4 series boards" like in this patch. But it doesn't look nice > (because R5S will go before R4S). > > There is already similar ordering (alphabetical/chronological for > model) for Radxa Rock Pi - "Radxa ROCK Pi S", "Radxa Rock2 Square", > "Radxa ROCK3 Model A", "Radxa ROCK 5 Model A". > > However if you want me to sort it strictly alphabetically, I can send a v2. No, it's fine, I also got a bit mislead by R2S (I thought it is RS2). Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
