Hi Prabhakar, On Wed, Mar 8, 2023 at 12:08 PM Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > On Mon, Mar 6, 2023 at 7:27 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > On Thu, Feb 16, 2023 at 6:57 PM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > > > OV5645 sensor can be connected to the CN1 connector on the > > > carrier board. This patch adds the ov5645 node under i2c0 node. > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Thanks for your patch! > > > > > --- a/arch/arm64/boot/dts/renesas/r9a07g044l2-smarc.dts > > > +++ b/arch/arm64/boot/dts/renesas/r9a07g044l2-smarc.dts > > > @@ -6,6 +6,10 @@ > > > */ > > > > > > /dts-v1/; > > > + > > > +/* comment the #define statement if OV5645 is not connected to CN1 */ > > > +#define CAM_INTERFACE_OV5645 1 > > > > I believe the camera is optional ("can be connector" above). > > So shouldn't this be commented out by default? > > > Yep, that makes sense. > > Shall I send this change or will you be generous to do this while applying ;) As this has an unresolved dependency on "[PATCH v2 0/2] Share RZ/G2L SoC DTSI with RZ/V2L SoC", I cannot do that yet... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds