On Tue, Mar 07, 2023 at 07:00:08PM +0100, Christian Marangi wrote: > On Wed, Mar 08, 2023 at 12:17:51AM +0100, Andrew Lunn wrote: > > On Tue, Mar 07, 2023 at 06:00:38PM +0100, Christian Marangi wrote: > > > From: Andrew Lunn <andrew@xxxxxxx> > > > > > > Define common binding parsing for all PHY drivers with LEDs using > > > phylib. Parse the DT as part of the phy_probe and add LEDs to the > > > linux LED class infrastructure. For the moment, provide a dummy > > > brightness function, which will later be replaced with a call into the > > > PHY driver. > > > > > > Signed-off-by: Andrew Lunn <andrew@xxxxxxx> > > > > Hi Christian > > > > Since you are submitting this, you need to add your own Signed-off-by: > > after mine. > > > > Tought it was needed only for patch where I have put any change. (case > of 2 patch in this series where there was a whitespace error and had to > change a binding) > > Think I need do to this for every other patch right? https://www.kernel.org/doc/html/latest/process/submitting-patches.html says: Any further SoBs (Signed-off-by:’s) following the author’s SoB are from people handling and transporting the patch, but were not involved in its development. SoB chains should reflect the real route a patch took as it was propagated to the maintainers and ultimately to Linus, with the first SoB entry signalling primary authorship of a single author. So yes, you need to add your Signed-off-by to all my patches, independent of if you make changes or not. Andrew
