On Tue, Mar 7, 2023 at 2:26 PM Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote: > Add bindings for the 2000x1200px IPS panel found on Lenovo Tab P11/ > XiaoXin Pad devices. > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> (...) > +$id: http://devicetree.org/schemas/display/panel/lenovo,nt36523w-boe-j606.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NT36523W BOE panel found on Lenovo J606 devices It's a Novatek NT36523 display controller-based device isn't it? I would reflect that in the title or at least the description. > + > +maintainers: > + - Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: lenovo,nt36523w-boe-j606 > + > + reg: > + maxItems: 1 > + description: DSI virtual channel > + > + vddio-supply: true > + reset-gpios: true > + rotation: true > + port: true This is clearly (as can be seen from the magic in the driver) a Novatek NT36523 display controller, just configured differently. https://lore.kernel.org/lkml/20230220121258.10727-1-lujianhua000@xxxxxxxxx/T/ Why can't you just modify the existing nt36523 binding from Jianhua Lu by e.g. making these two non-required: - vddpos-supply - vddneg-supply It would not be helpful for driver writers to have two different bindings for similar hardware hand having to write code to handle different properties depending on which binding is used, so please unify into one binding by cooperating with Jianhua. Would it help if we merged Jianhua's binding so you can build on top? Yours, Linus Walleij
